Ensure status.version is reconciled by watching Pods #3534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did not enqueue reconciliations on Pods changes in Kibana, APMServer and Beats controllers. We did on Elasticsearch and EnterpriseSearch controllers. When controllers rely on information retrieved from Pods as part of the reconciliation, not watching Pods can lead to missing some events. This is especially true for the `status.version` field in all resources. Note this particular case could have been worked out differently, by checking the replicas sets for example. I think the implementation would be more complicated, and we already watch all Pods due to the Elasticsearch and EnterpriseSearch controllers anyway. This commit sets up a single helper function called from all controllers.
sebgl
changed the title
This was referenced Jul 27, 2020
pebrc
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not enqueue reconciliations on Pods changes in Kibana, APMServer
and Beats controllers. We did on Elasticsearch and EnterpriseSearch
controllers.
When controllers rely on information retrieved from Pods as
part of the reconciliation, not watching Pods can lead to missing some
events.
This is especially true for the
status.versionfield in all resources.Note this particular case could have been worked out differently, by
checking the ReplicaSets for example. I think the implementation would
be more complicated, and we already watch all Pods due to the
Elasticsearch and EnterpriseSearch controllers anyway.
This commit sets up a single helper function called from all
controllers.
Fixes #3533.