Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary memory leak mitigation patch #3585

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Remove unnecessary memory leak mitigation patch #3585

merged 1 commit into from
Aug 11, 2020

Conversation

barkbay
Copy link
Contributor

@barkbay barkbay commented Aug 5, 2020

@barkbay barkbay added >enhancement Enhancement of existing functionality v1.3.0 labels Aug 5, 2020
@pebrc
Copy link
Collaborator

pebrc commented Aug 10, 2020

I believe there is little reason for scheduling a requeue for more than 10 hours in the future as the Go client cache refresh interval is by default 10 hours IIRC

@barkbay
Copy link
Contributor Author

barkbay commented Aug 11, 2020

I believe there is little reason for scheduling a requeue for more than 10 hours in the future as the Go client cache refresh interval is by default 10 hours IIRC

I don't know if waiting for the cache to be refreshed is enough, it would also need to generate an event which would not be the case if the cache is in sync ?

@barkbay barkbay merged commit d34d62f into elastic:master Aug 11, 2020
@david-kow david-kow changed the title Remove memory leak mitigation Remove unnecessary memory leak mitigation patch Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pebrc pebrc pebrc approved these changes

Assignees
No one assigned
Labels
>enhancement Enhancement of existing functionality v1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barkbay @pebrc