Do not reset trial state once a license has been issued. #3662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses an issue observed when the trial status secret would not be found due to an outdated client cache and the trial controller would reinitialise the trial state from scratch invalidating an already issued license.
pebrc
commented
Aug 25, 2020
sebgl
reviewed
Aug 25, 2020
barkbay
pushed a commit
to barkbay/cloud-on-k8s
that referenced
this pull request
Sep 2, 2020
Addresses an issue observed when the trial status secret would not be found due to an outdated client cache and the trial controller would re-initialise the trial state from scratch invalidating an already issued license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3659
Addresses an issue observed when the trial status secret would not be found due to an outdated client cache and the trial controller would re-initialise the trial state from scratch invalidating an already issued license.
This PR checks therefore for
trialState.IsEmptyinstead oftrialState.IsTrialStarted.