Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new authentication configuration format starting EnterpriseSearch 8.x #3728

Merged
merged 5 commits into from
Sep 9, 2020

Conversation

thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Sep 8, 2020

Resolves #3725.

@thbkrkr thbkrkr added >bug Something isn't working v1.3.0 labels Sep 8, 2020
pkg/controller/enterprisesearch/config.go Outdated Show resolved Hide resolved
pkg/controller/enterprisesearch/config.go Outdated Show resolved Hide resolved
pkg/controller/enterprisesearch/config.go Show resolved Hide resolved
@thbkrkr thbkrkr removed the >bug Something isn't working label Sep 8, 2020
@botelastic botelastic bot added the triage label Sep 8, 2020
@thbkrkr thbkrkr added the >bug Something isn't working label Sep 8, 2020
@botelastic botelastic bot removed the triage label Sep 8, 2020
@thbkrkr thbkrkr requested a review from barkbay September 9, 2020 09:44
Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a test with *:8.0.0-SNAPSHOT docker images, I have the following errors in the logs:

[2020-09-09T13:45:29.604+00:00][1][2422][worker][ERROR]: Error in processing loop; Sleeping for 4s before trying again
Elasticsearch::Transport::Transport::Errors::BadRequest ([400] {"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"invalid parameter [size], use [max_docs] instead"}],"type":"illegal_argument_exception","reason":"invalid parameter [size], use [max_docs] instead"},"status":400})
	/usr/share/enterprise-search/lib/war/gems/gems/elasticsearch-transport-7.0.0/lib/elasticsearch/transport/transport/base.rb:218:in `__raise_transport_error'
	/usr/share/enterprise-search/lib/war/gems/gems/elasticsearch-transport-7.0.0/lib/elasticsearch/transport/transport/base.rb:338:in `perform_request'
	/usr/share/enterprise-search/lib/war/gems/gems/elasticsearch-transport-7.0.0/lib/elasticsearch/transport/transport/http/faraday.rb:37:in `perform_request'
	/usr/share/enterprise-search/lib/war/gems/gems/elasticsearch-transport-7.0.0/lib/elasticsearch/transport/client.rb:160:in `perform_request'
	/usr/share/enterprise-search/lib/war/gems/gems/elasticsearch-api-7.0.0/lib/elasticsearch/api/actions/update_by_query.rb:88:in `update_by_query'
	/usr/share/enterprise-search/lib/war/vendor/esqueues-me/lib/esqueues_me/worker.rb:123:in `claim_work'
	/usr/share/enterprise-search/lib/war/vendor/esqueues-me/lib/esqueues_me/worker.rb:98:in `work'
	/usr/share/enterprise-search/lib/war/vendor/esqueues-me/lib/esqueues_me/worker.rb:69:in `block in start_processing_loop!'
	org/jruby/RubyKernel.java:1446:in `loop'
	/usr/share/enterprise-search/lib/war/vendor/esqueues-me/lib/esqueues_me/worker.rb:63:in `start_processing_loop!'
	/usr/share/enterprise-search/lib/war/vendor/esqueues-me/lib/esqueues_me.rb:106:in `start!'
	/usr/share/enterprise-search/lib/war/shared_togo/lib/shared_togo.class:732:in `start_esqueues_me!'
	/usr/share/enterprise-search/lib/war/shared_togo/lib/shared_togo.class:145:in `start_worker!'
	<script>:1:in `<main>'

But it does not seem related to an authentication problem, so LGTM.

@thbkrkr
Copy link
Contributor Author

thbkrkr commented Sep 9, 2020

I did not see that but it might be worth contacting the ENT team about this if we know how to reproduce it. It seems related to elastic/elasticsearch#43373. The log indicates elasticsearch-api-7.0.0 is still in use.

@thbkrkr thbkrkr merged commit 7cf6014 into elastic:master Sep 9, 2020
@thbkrkr thbkrkr deleted the new-auth-config-format-for-ent-8x branch October 16, 2020 08:12
@david-kow david-kow changed the title Support new auth config format starting EnterpriseSearch 8.x Support new authentication configuration format starting EnterpriseSearch 8.x Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug Something isn't working v1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the new auth config format starting EnterpriseSearch 8.X
3 participants