Create one transport certificates Secret per StatefulSet #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pebrc
reviewed
Oct 13, 2020
pkg/controller/elasticsearch/certificates/transport/reconcile.go
Outdated
Show resolved
Hide resolved
pebrc
approved these changes
Oct 14, 2020
I think I would be 👍 once I see all the e2e tests green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the transport certificates are stored in one Secret per
nodeSet/StatefulSet.Secretis deleted only when the StatefulSets specifications have been updated (I did some tests and it seems to be fine to delete a Secret which is used by a Pod, the content is still available until the Pod is deleted).Secretsare named*-transport-certsand not*-transport-certificatesto save a few characters and be consistent with otherSecrets(*-[http|transport]-certs-public,*-[http|transport]-certs-internal)Fixes (or only mitigates ?) #3734