[Helm] Add optional podLabels to operator pod and Expose Metrics ports

[oliverbaehler]

Signed-off-by: Oliver Bähler oliver.baehler@bedag.ch

This Pull Request adds two new features:

1. If the config.metricsPort value is not 0 a port on the container is exposed with that value. Currently this port is not exposed which makes it impossible for a prometheus monitor to scrape them.
2. podLabels adds the option to label the operator pod with additional labels. We currently have the use case that we need to add some labels to the pod and that option currently does not exist.

I was also wondering if it would be interesting to have a prometheus serviceMonitor built-in to the chart? So that endusers could just flick some options and have their metrics scraped by prometheus. Let me know if that's something you see would add value to the chart and I will be willing to commit the code to this pull request :).

• Have you signed the contributor license agreement?
• Have you followed the contributor guidelines?
• If you submit code, is your pull request against master? We recommend pull requests against master. We will backport them as needed.

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[cla-checker-service]

💚 CLA has been signed

[pebrc]

Jenkins test this please.

[oliverbaehler]

My latests commit adds the option to deploy a podMonitor with the eck-operator. I tested it locally and it seemed to work fine. Let me know what you think :)

[oliverbaehler]

Is there any timeframe on when this will be included? :) (if even)

[barkbay]

Jenkins test this please

[barkbay]

LGTM

For the record I did a test using the following Prometheus resource:

apiVersion: monitoring.coreos.com/v1
kind: Prometheus
metadata:
  name: prometheus
  namespace: prom
spec:
  podMonitorNamespaceSelector:
    matchLabels:
      prometheus: monitoring
  podMonitorSelector:
    matchLabels:
      team: eck

Once created the operator namespace has been labeled with prometheus=monitoring

Then the Helm chart has been deployed with the following command:

% helm install --devel --debug my-elastic-operator my-eck/eck-operator --set=config.metricsPort=9090  --set=image.tag=1.5.0 --set=podMonitor.enabled=true --set=podMonitor.labels.team=eck

Which triggered the creation of the podMonitor resource:

% k get podmonitors.monitoring.coreos.com
NAME               AGE
elastic-operator   2m30s

I was also able to get the operator metrics in the Prometheus console.

Thanks !