Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module sigs.k8s.io/controller-runtime to v0.9.1 #4587

Merged
merged 4 commits into from
Jul 1, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 21, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Type Update Change
sigs.k8s.io/controller-runtime require patch v0.9.0 -> v0.9.1

Release Notes

kubernetes-sigs/controller-runtime

v0.9.1

Compare Source

Changes since v0.9.0

✨ New Features

🌱 Others

  • Update dependencies to Kubernetes v1.21.2 (#​1561)

Thanks to all our contributors! 😊


Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the >renovate PRs created by or relating to Renovate label Jun 21, 2021
@thbkrkr
Copy link
Contributor

thbkrkr commented Jun 22, 2021

@elasticmachine run elasticsearch-ci/docs

@thbkrkr thbkrkr self-assigned this Jun 22, 2021
@thbkrkr
Copy link
Contributor

thbkrkr commented Jun 22, 2021

Regression or flaky test?

[2021-06-22T15:03:18.601Z] === FAIL: pkg/controller/common/watches TestDynamicEnqueueRequest (30.20s)
[2021-06-22T15:03:18.601Z] {"log.level":"info","@timestamp":"2021-06-22T15:02:44.731Z","log.logger":"controller-runtime.manager.controller.test-reconciler","message":"Starting EventSource","service.version":"0.0.0-SNAPSHOT+00000000","service.type":"eck","ecs.version":"1.4.0","source":"kind source: /, Kind="}
[2021-06-22T15:03:18.601Z] {"log.level":"info","@timestamp":"2021-06-22T15:02:44.732Z","log.logger":"controller-runtime.manager.controller.test-reconciler","message":"Starting Controller","service.version":"0.0.0-SNAPSHOT+00000000","service.type":"eck","ecs.version":"1.4.0"}
[2021-06-22T15:03:18.601Z] {"log.level":"info","@timestamp":"2021-06-22T15:02:44.835Z","log.logger":"controller-runtime.manager.controller.test-reconciler","message":"Starting workers","service.version":"0.0.0-SNAPSHOT+00000000","service.type":"eck","ecs.version":"1.4.0","worker count":1}
[2021-06-22T15:03:18.601Z] {"log.level":"debug","@timestamp":"2021-06-22T15:02:44.844Z","log.logger":"dynamic-enqueue-request","message":"Adding new handler registration","service.version":"0.0.0-SNAPSHOT+00000000","service.type":"eck","ecs.version":"1.4.0","key":"test-watch-1","current_registrations":{}}
[2021-06-22T15:03:18.601Z] {"log.level":"info","@timestamp":"2021-06-22T15:02:44.863Z","log.logger":"controller-runtime.manager.controller.test-reconciler","message":"Shutdown signal received, waiting for all workers to finish","service.version":"0.0.0-SNAPSHOT+00000000","service.type":"eck","ecs.version":"1.4.0"}
[2021-06-22T15:03:18.601Z]     integration.go:97: 
[2021-06-22T15:03:18.601Z]         	Error Trace:	integration.go:97
[2021-06-22T15:03:18.601Z]         	            				handler_integration_test.go:82
[2021-06-22T15:03:18.601Z]         	Error:      	Received unexpected error:
[2021-06-22T15:03:18.601Z]         	            	failed waiting for all runnables to end within grace period of 30s: context deadline exceeded
[2021-06-22T15:03:18.601Z]         	Test:       	TestDynamicEnqueueRequest

@thbkrkr
Copy link
Contributor

thbkrkr commented Jun 22, 2021

jenkins test this please

Edit: The test passed. So I would say it's flaky.

@thbkrkr
Copy link
Contributor

thbkrkr commented Jun 23, 2021

@elasticmachine run elasticsearch-ci/docs

@thbkrkr
Copy link
Contributor

thbkrkr commented Jun 23, 2021

TestDynamicEnqueueRequest failed again. Not good. I wonder if it's related to the dependencies update to Kubernetes v1.21.2.

jenkins test this please

Edit: The test passed again.

@thbkrkr
Copy link
Contributor

thbkrkr commented Jul 1, 2021

TestDynamicEnqueueRequest also failed once in another PR which still uses controller-runtime 0.8.3. It could be a transient flaky failure related to the jenkins test environment. Let's keep an eye on the PR job but let's not block this PR because it doesn't seem to be related.

@thbkrkr thbkrkr merged commit c033494 into master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>renovate PRs created by or relating to Renovate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants