Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop "properties: {}" from empty-v1alpha1-patch #4813

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Drop "properties: {}" from empty-v1alpha1-patch #4813

merged 2 commits into from
Sep 8, 2021

Conversation

kingcrunch
Copy link
Contributor

Kubernetes will remove this empty property anyway. Gitop Tools like ArgoCD will treat this as drift and constantly tries to reconcile

Kubernetes will remove this empty property anyway. Gitop Tools like ArgoCD will treat this as drift and constantly tries to reconcile
@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Sep 2, 2021

💚 CLA has been signed

@botelastic botelastic bot added the triage label Sep 2, 2021
@thbkrkr thbkrkr added the >enhancement Enhancement of existing functionality label Sep 8, 2021
@botelastic botelastic bot removed the triage label Sep 8, 2021
@thbkrkr
Copy link
Contributor

thbkrkr commented Sep 8, 2021

Thanks for the contribution!

@elastic elastic deleted a comment from elasticmachine Sep 8, 2021
@elastic elastic deleted a comment from elasticmachine Sep 8, 2021
@elastic elastic deleted a comment from elasticmachine Sep 8, 2021
@elastic elastic deleted a comment from elasticmachine Sep 8, 2021
@thbkrkr
Copy link
Contributor

thbkrkr commented Sep 8, 2021

I ran make generate and updated the PR for you.

@thbkrkr
Copy link
Contributor

thbkrkr commented Sep 8, 2021

Jenkins test this please

Copy link
Contributor

@thbkrkr thbkrkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thbkrkr thbkrkr added the v1.8.0 label Sep 8, 2021
@thbkrkr thbkrkr merged commit 7177896 into elastic:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Enhancement of existing functionality v1.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants