Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 8.0.0 related issues in E2E #4931

Merged
merged 5 commits into from
Oct 13, 2021
Merged

Conversation

david-kow
Copy link
Contributor

@david-kow david-kow commented Oct 7, 2021

This PR fixes a number of issues that prevent E2E tests from passing on 8.0.0-alpha2:

  • ignore all suffixes (not only -SNAPSHOT) when checking APM Server version
  • don't provide ent_search.auth.* settings in Enterprise Search config for 8.0.0+
  • use monitoring.ui.container.elasticsearch.enabled instead of xpack.monitoring.ui.container.elasticsearch.enabled in Kibana config for 7.16.0+
  • use node.roles instead of node.data: true etc. in Elasticsearch config for7.9.0+ E2E tests and manifests
  • set kibana.host setting in Enterprise Search config for 8.0.0+ E2E tests
  • inspect metricbeat-* instead of .monitoring-kibana-* index for checking Stack Monitoring data in Elasticsearch and Kibana
  • check for level == available instead of state == green field when checking Kibana health
  • check /internal/workplace_search/overview instead of /api/enterprise_search/config_data API when checking Enterprise Search UI availability in Kibana
  • Temporarily disable TestVolumeMultiDataPath test for 8.x as the feature deprecation revert is still in progress

@david-kow david-kow added the >test Related to unit/integration/e2e tests label Oct 7, 2021
@david-kow
Copy link
Contributor Author

jenkins test this please

@david-kow
Copy link
Contributor Author

run full pr build

@david-kow
Copy link
Contributor Author

Tests look good, the only failure (below) is caused by using nodes.roles notion in pre-7.9.0 ES versions.

Screenshot 2021-10-08 at 23 21 38

This is fixed in 455e60c.

@david-kow
Copy link
Contributor Author

jenkins test this please

07:48:47          	            				handler_integration_test.go:82
07:48:47          	Error:      	Received unexpected error:
07:48:47          	            	failed waiting for all runnables to end within grace period of 30s: context deadline exceeded
07:48:47          	Test:       	TestDynamicEnqueueRequest```

Copy link
Collaborator

@pebrc pebrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/controller/common/version/version.go Outdated Show resolved Hide resolved
test/e2e/es/volume_test.go Outdated Show resolved Hide resolved
test/e2e/test/kibana/checks_kb.go Show resolved Hide resolved
test/e2e/test/elasticsearch/builder.go Outdated Show resolved Hide resolved
test/e2e/test/elasticsearch/builder.go Show resolved Hide resolved
test/e2e/test/kibana/builder.go Outdated Show resolved Hide resolved
@david-kow david-kow merged commit 5990a53 into elastic:master Oct 13, 2021
@david-kow david-kow deleted the e2e_fixes_80 branch October 13, 2021 07:20
fantapsody pushed a commit to fantapsody/cloud-on-k8s that referenced this pull request Feb 7, 2023
* 8.0 E2E fixes

* PR fixes

* Disable temporarly multi data path test for 8.0

* Fix kibana port

* PR fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>test Related to unit/integration/e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants