-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add log4j2.formatMsgNoLookups logging property to ES < 7.2 #5157
Merged
thbkrkr
merged 7 commits into
elastic:master
from
thbkrkr:add-jvm-logging-property-to-possibly-mitigate-Log4Shell
Dec 14, 2021
Merged
Add log4j2.formatMsgNoLookups logging property to ES < 7.2 #5157
thbkrkr
merged 7 commits into
elastic:master
from
thbkrkr:add-jvm-logging-property-to-possibly-mitigate-Log4Shell
Dec 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thbkrkr
force-pushed
the
add-jvm-logging-property-to-possibly-mitigate-Log4Shell
branch
from
December 13, 2021 16:07
e9f497f
to
8ac9958
Compare
barkbay
reviewed
Dec 13, 2021
Co-authored-by: Michael Morello <michael.morello@gmail.com>
Co-authored-by: Michael Morello <michael.morello@gmail.com>
barkbay
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a few tests with 6.8.21
, 7.1.1
, LGTM
Co-authored-by: Michael Morello <michael.morello@gmail.com>
david-kow
pushed a commit
to david-kow/cloud-on-k8s
that referenced
this pull request
Dec 15, 2021
CVE-2021-44228 (elastic#5157) Prepends the JVM parameter -Dlog4j2.formatMsgNoLookups=true to the environment variable ES_JAVA_OPTS in order to mitigate the Log4Shell vulnerability CVE-2021-44228, if it is not yet defined by the user, for versions of Elasticsearch before 7.2.0. # Conflicts: # pkg/controller/elasticsearch/nodespec/podspec.go
david-kow
added a commit
that referenced
this pull request
Dec 15, 2021
… vulnerability CVE-2021-44228 (#5157) (#5164) * Configure JVM logging for ES < 7.12 to mitigate Log4Shell vulnerability CVE-2021-44228 (#5157) Prepends the JVM parameter -Dlog4j2.formatMsgNoLookups=true to the environment variable ES_JAVA_OPTS in order to mitigate the Log4Shell vulnerability CVE-2021-44228, if it is not yet defined by the user, for versions of Elasticsearch before 7.2.0. # Conflicts: # pkg/controller/elasticsearch/nodespec/podspec.go * Fixing bad conflict resolution * Fix backport merge issue * PR fixes Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
david-kow
changed the title
Add log4j2.formatMsgNoLookups logging property to ES < 7.12
Add log4j2.formatMsgNoLookups logging property to ES < 7.2
Dec 16, 2021
thbkrkr
deleted the
add-jvm-logging-property-to-possibly-mitigate-Log4Shell
branch
January 4, 2022 14:10
fantapsody
pushed a commit
to fantapsody/cloud-on-k8s
that referenced
this pull request
Feb 7, 2023
CVE-2021-44228 (elastic#5157) Prepends the JVM parameter -Dlog4j2.formatMsgNoLookups=true to the environment variable ES_JAVA_OPTS in order to mitigate the Log4Shell vulnerability CVE-2021-44228, if it is not yet defined by the user, for versions of Elasticsearch before 7.2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepends the JVM parameter
-Dlog4j2.formatMsgNoLookups=true
to the environment variableES_JAVA_OPTS
in order to mitigate the Log4Shell vulnerability CVE-2021-44228, if it is not yet defined by the user,
for versions of Elasticsearch before
7.2.0
.