Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add latest APM fleet package in Kibana examples when using standalone APM server. #6063

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Add latest APM fleet package in Kibana examples when using standalone APM server. #6063

merged 2 commits into from
Oct 4, 2022

Conversation

naemono
Copy link
Contributor

@naemono naemono commented Oct 3, 2022 •
edited
Loading

resolves #5059

This change updates all of our standalone APM Server examples to include the latest APM fleet package in the Kibana resource.

@naemono naemono added >enhancement Enhancement of existing functionality >docs Documentation labels Oct 3, 2022
thbkrkr
thbkrkr reviewed Oct 4, 2022
View reviewed changes
Copy link
Contributor

@thbkrkr thbkrkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add a note in the APM documentation as this may still be difficult to find out?

config/recipes/traefik/02-elastic-stack.yaml Outdated Show resolved Hide resolved
@naemono @thbkrkr
fix ordering of spec.
5c353f6 
Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
thbkrkr
thbkrkr approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@thbkrkr thbkrkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the standalone APM server is deprecated and this config is not mentioned in the APM documentation, I think we can leave it at that by just updating the samples.

@naemono naemono merged commit c587aed into elastic:main Oct 4, 2022
@naemono naemono deleted the 5059-fix-apmserver-standalone-samples branch October 4, 2022 18:54
@thbkrkr thbkrkr added the v2.6.0 label Oct 4, 2022
@thbkrkr thbkrkr removed the >enhancement Enhancement of existing functionality label Jan 5, 2023
@pebrc pebrc mentioned this pull request Feb 7, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thbkrkr thbkrkr thbkrkr approved these changes

Assignees
No one assigned
Labels
>docs Documentation v2.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update APM Server examples/samples for 8.0.0
2 participants
@naemono @thbkrkr