Add container-suffix operator flag to allow users to specify a container suffix to be applied across all Elastic stack container images #6086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barkbay
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
LGTM!
If we want this flag to be available with Helm I think we should also update the ConfigMap template.
| cmd.Flags().String( | ||
| operator.ContainerSuffixFlag, | ||
| "", | ||
| fmt.Sprintf("Suffix to be appended to container images by default. Cannot be combined with %s", operator.UBIOnlyFlag), |
There was a problem hiding this comment.
nit: maybe do the same for the UBI flag?
cmd.Flags().Bool(
operator.UBIOnlyFlag,
false,
fmt.Sprintf("Use only UBI container images to deploy Elastic Stack applications. UBI images are only available from 7.10.0 onward. Cannot be combined with %s", operator.ContainerSuffixFlag),
)And do a similar change in the doc?
There was a problem hiding this comment.
There are other flags not available in Helm. I created an issue to follow this:
naemono
changed the title
thbkrkr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6064
--container-suffixallows users to set a default suffix for container images that will be applied whenever the operator defaults to setting the image used. That is the case whenever the user does not explicitly specify theimageattribute on a Elastic Stack resource manifest.It is illegal to combine both
--ubi-onlyand--container-suffixbecause--ubi-onlyalready implies a container suffix of-ubi