Call _nodes/shutdown from pre-stop hook #6544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barkbay
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
I have not tested all the combinations but LGTM.
Note that this PR will trigger a cluster restart, we should also update https://www.elastic.co/guide/en/cloud-on-k8s/current/k8s-upgrading-eck.html#k8s-beta-to-ga-rolling-restart accordingly.
pebrc
commented
Mar 20, 2023
thbkrkr
reviewed
Mar 20, 2023
docs/orchestrating-elastic-stack-applications/elasticsearch/prestop.asciidoc
Outdated
Show resolved
Hide resolved
pebrc
commented
Mar 20, 2023
…estop.asciidoc Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
barkbay
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
LGTM, I did a bit of manual testing and it seems to work as expected.
As you mentioned in a comment the only thing I'm afraid of would be an unexpected behaviour because the Pod's metadata would not be up to date in the client cache. This adds another "best-effort" layer 😄
thbkrkr
reviewed
Mar 21, 2023
thbkrkr
reviewed
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6478
Adds a more complicated shell script to the pre-stop lifecycle hook. This is covers the uses case described in the referenced issue which affect mostly larger clusters with lots of data.
This is obviously a best effort attempt at orchestrating node shutdown more gracefully. Many things can go wrong here. I anticipate that the most common reason why this logic might fail is on slow or not responding ES clusters where we might run into the overall lifecycle hook timeout.
There is some fragile grep'ing over JSON responses here as well because we don't have
jqor similar tools available in the Elasticsearch image.