Add PodDisruptionBudget to eck-operator Helm chart #6671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thbkrkr
requested changes
Apr 11, 2023
Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
|
@thbkrkr Thank you for all the suggestions. I've updated the PR. |
|
@elasticmachine run elasticsearch-ci/docs |
|
buildkite test this |
thbkrkr
approved these changes
Apr 11, 2023
naemono
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
The only bit I was concerned about was validating an invalid pdb, which k8s does for us:
helm upgrade -i elastic-operator . -n elastic-system --values ~/tmp/eck-operator-standard.yaml --set=installCRDs=false --set=podDisruptionBudget.enabled=true --set=podDisruptionBudget.maxUnavailable=2
Error: UPGRADE FAILED: cannot patch "elastic-operator" with kind PodDisruptionBudget: PodDisruptionBudget.policy "elastic-operator" is invalid: spec: Invalid value: policy.PodDisruptionBudgetSpec{MinAvailable:(*intstr.IntOrString)(0xc04181de80), Selector:(*v1.LabelSelector)(0xc04181dea0), MaxUnavailable:(*intstr.IntOrString)(0xc04181dec0)}: minAvailable and maxUnavailable cannot be both set
My testing showed this working as intended, so 👍
thbkrkr
changed the title
thbkrkr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow PodDisruptionBudget be configured via parameter for eck-operator statefulset deployment.