Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing page updated with Helm chart tests suite #6744

Merged
merged 3 commits into from
May 4, 2023

Conversation

unknovvn
Copy link
Contributor

Changes according to ticket

@botelastic botelastic bot added the triage label Apr 29, 2023
Copy link
Contributor

@naemono naemono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. Would love a member of @elastic/docs to take a look as well. Nevermind on the Docs team, this is only our contributing doc.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Michael Montgomery <mmontg1@gmail.com>
Copy link
Contributor

@naemono naemono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@naemono
Copy link
Contributor

naemono commented May 2, 2023

@elasticmachine run elasticsearch-ci/docs

@naemono
Copy link
Contributor

naemono commented May 2, 2023

closes #6729

@barkbay
Copy link
Contributor

barkbay commented May 3, 2023

buildkite test this

@barkbay barkbay added the >docs Documentation label May 3, 2023
@botelastic botelastic bot removed the triage label May 3, 2023
@botelastic botelastic bot removed the triage label May 3, 2023
@barkbay barkbay merged commit 24f6afa into elastic:main May 4, 2023
@barkbay barkbay changed the title Contributing page updated with helm chart tests suit Contributing page updated with Helm chart tests suit May 15, 2023
@barkbay barkbay changed the title Contributing page updated with Helm chart tests suit Contributing page updated with Helm chart tests suite May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs Documentation v2.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants