SAML documentation examples no longer use a deprecated callback URL #7117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pebrc
approved these changes
Aug 25, 2023
|
buildkite build this |
|
@elasticmachine , run elasticsearch-ci/docs |
|
@elasticmachine , run elasticsearch-ci/docs |
|
buildkite build this |
In https://github.com/elastic/kibana/blob/b33effa182bcb7c9620c5435ab252d8067732655/x-pack/plugins/security/server/routes/authentication/saml.ts#L27 `/api/security/saml/callback` is the correct URL, while `/api/security/v1/saml` is the deprecated URL. Signed-off-by: Craig Rodrigues <rodrigc@crodrigues.org>
auto-merge was automatically disabled
August 25, 2023 13:16
Head branch was pushed to by a user without write access
|
@pebrc I fixed some merge conflicts which I think was causing buildkite to fail. |
|
buildkite build this |
|
@elasticmachine , run elasticsearch-ci/docs |
|
@pebrc Thanks! |
rhr323
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/elastic/kibana/blob/b33effa182bcb7c9620c5435ab252d8067732655/x-pack/plugins/security/server/routes/authentication/saml.ts#L27
/api/security/saml/callbackis the correct URL,while
/api/security/v1/samlis the deprecated URL.Fixes: #7118
Signed-off-by: Craig Rodrigues rodrigc@crodrigues.org