Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module sigs.k8s.io/controller-runtime to v0.16.2 #7185

Merged
merged 5 commits into from
Sep 28, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 26, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
sigs.k8s.io/controller-runtime require patch v0.16.0 -> v0.16.2

Release Notes

kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)

v0.16.2

Compare Source

What's Changed

Full Changelog: kubernetes-sigs/controller-runtime@v0.16.1...v0.16.2

v0.16.1

Compare Source

What's Changed

Full Changelog: kubernetes-sigs/controller-runtime@v0.16.0...v0.16.1


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the >renovate PRs created by or relating to Renovate label Sep 26, 2023
@renovate renovate bot force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch from d7f2f68 to 50495d7 Compare September 26, 2023 16:55
@barkbay
Copy link
Contributor

barkbay commented Sep 27, 2023

{"log.level":"debug","@timestamp":"2023-09-27T05:12:57.783Z","message":"StatefulSets observedGeneration is not reconciled yet, re-queueing","service.version":"0.0.0-SNAPSHOT+00000000","service.type":"eck","ecs.version":"1.4.0","namespace":"ns","es_name":"cluster"}
--
  | expectations_test.go:65:
  | Error Trace:	/buildkite/builds/bk-agent-prod-k8s-1695791442689292339/elastic/cloud-on-k8s-operator/pkg/controller/elasticsearch/driver/expectations_test.go:65
  | Error:      	Should be true
  | Test:       	Test_defaultDriver_expectationSatisfied

I wonder if it's related to kubernetes-sigs/controller-runtime#2485

@barkbay
Copy link
Contributor

barkbay commented Sep 27, 2023

I removed workaroundStatusUpdateError in the last commit. I don't think it's still useful as 1.15 is no longer supported for quite a while, and using client.Update() to update the status seems wrong.

@barkbay
Copy link
Contributor

barkbay commented Sep 27, 2023

@elasticmachine run elasticsearch-ci/docs

@renovate
Copy link
Contributor Author

renovate bot commented Sep 27, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@thbkrkr
Copy link
Contributor

thbkrkr commented Sep 27, 2023

@elasticmachine run elasticsearch-ci/docs

@barkbay barkbay merged commit f58883e into main Sep 28, 2023
@barkbay barkbay deleted the renovate/sigs.k8s.io-controller-runtime-0.x branch September 28, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>renovate PRs created by or relating to Renovate v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants