Better sample command outputs in the Agent Fleet documentation #7213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**:: Background:** - The manifest says `xxx-quickstart`, i.e. `fleet-server-quickstart`, - however, the sample response says things without `-quickstart`…
thbkrkr
approved these changes
Oct 10, 2023
thbkrkr
changed the title
thbkrkr
pushed a commit
to thbkrkr/cloud-on-k8s
that referenced
this pull request
Oct 10, 2023
…ic#7213) This adds `-quickstart` in sample command outputs, i.e. change pod name from elastic-agent-agent-t49fd to elastic-agent-quickstart-agent-t49fd, so as to keep the sample yaml manifest and the sample command outputs, aligned and easy to follow.
thbkrkr
added a commit
that referenced
this pull request
Oct 10, 2023
#7214) This adds `-quickstart` in sample command outputs, i.e. change pod name from elastic-agent-agent-t49fd to elastic-agent-quickstart-agent-t49fd, so as to keep the sample yaml manifest and the sample command outputs, aligned and easy to follow. Co-authored-by: Kuni Sen <30574753+kunisen@users.noreply.github.com>
rhr323
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
xxx-quickstart, i.e.fleet-server-quickstart,-quickstart…TL;DR:
This PR is to add
-quickstartin sample response part, i.e. change pod name fromelastic-agent-agent-t49fdtoelastic-agent-quickstart-agent-t49fd, so as to keep the sample yaml manifest and the sample response aligned and easy to follow.cc @thbkrkr as we chatted this internally. Thanks for your quick response! 🙏