Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring "ca-dir" operator setting via helm #7243

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

jbouse
Copy link
Contributor

@jbouse jbouse commented Oct 17, 2023

Adds support for the ca-dir setting in the configMap as mentioned in #6435 and #6091.

Closes elastic#6435 and addresses some of  elastic#6091

Signed-off-by: Jeremy T. Bouse <Jeremy.Bouse@UnderGrid.net>
@botelastic botelastic bot added the triage label Oct 17, 2023
@thbkrkr thbkrkr added the >enhancement Enhancement of existing functionality label Oct 18, 2023
@botelastic botelastic bot removed the triage label Oct 18, 2023
Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
@thbkrkr
Copy link
Contributor

thbkrkr commented Oct 18, 2023

@elasticmachine run elasticsearch-ci/docs

@thbkrkr
Copy link
Contributor

thbkrkr commented Oct 18, 2023

buildkite test this

Co-authored-by: Michael Montgomery <mmontg1@gmail.com>
Copy link
Collaborator

@pebrc pebrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbouse
Copy link
Contributor Author

jbouse commented Oct 19, 2023

I had tested it locally with both # caDir: "" and caDir: "" and the behavior was the same so I'd left it uncommented as it was the default value.

@thbkrkr
Copy link
Contributor

thbkrkr commented Oct 19, 2023

@elasticmachine run elasticsearch-ci/docs

@thbkrkr
Copy link
Contributor

thbkrkr commented Oct 19, 2023

buildkite test this

@thbkrkr thbkrkr merged commit e4b24b0 into elastic:main Oct 19, 2023
5 checks passed
thbkrkr pushed a commit to thbkrkr/cloud-on-k8s that referenced this pull request Oct 19, 2023
…es (elastic#7243)

This exposes the "ca-dir" operator setting for configuring a global CA path in the eck-operator 
Helm chart values.

---------
Signed-off-by: Jeremy T. Bouse <Jeremy.Bouse@UnderGrid.net>
Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
Co-authored-by: Michael Montgomery <mmontg1@gmail.com>
thbkrkr added a commit that referenced this pull request Oct 23, 2023
…es (#7243) (#7255)

This exposes the "ca-dir" operator setting for configuring a global CA path in the eck-operator 
Helm chart values.

---------
Signed-off-by: Jeremy T. Bouse <Jeremy.Bouse@UnderGrid.net>
Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
Co-authored-by: Michael Montgomery <mmontg1@gmail.com>
@rhr323 rhr323 changed the title Adds "ca-dir" settings to configMap for eck-operator Support configuring "ca-dir" operator setting via helm Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Enhancement of existing functionality :helm-charts v2.10.0 v2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants