-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support configuring "ca-dir" operator setting via helm #7243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes elastic#6435 and addresses some of elastic#6091 Signed-off-by: Jeremy T. Bouse <Jeremy.Bouse@UnderGrid.net>
thbkrkr
reviewed
Oct 18, 2023
Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
@elasticmachine run elasticsearch-ci/docs |
buildkite test this |
naemono
reviewed
Oct 19, 2023
Co-authored-by: Michael Montgomery <mmontg1@gmail.com>
pebrc
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I had tested it locally with both |
@elasticmachine run elasticsearch-ci/docs |
buildkite test this |
thbkrkr
pushed a commit
to thbkrkr/cloud-on-k8s
that referenced
this pull request
Oct 19, 2023
…es (elastic#7243) This exposes the "ca-dir" operator setting for configuring a global CA path in the eck-operator Helm chart values. --------- Signed-off-by: Jeremy T. Bouse <Jeremy.Bouse@UnderGrid.net> Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com> Co-authored-by: Michael Montgomery <mmontg1@gmail.com>
thbkrkr
added a commit
that referenced
this pull request
Oct 23, 2023
…es (#7243) (#7255) This exposes the "ca-dir" operator setting for configuring a global CA path in the eck-operator Helm chart values. --------- Signed-off-by: Jeremy T. Bouse <Jeremy.Bouse@UnderGrid.net> Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com> Co-authored-by: Michael Montgomery <mmontg1@gmail.com>
rhr323
changed the title
Adds "ca-dir" settings to configMap for eck-operator
Support configuring "ca-dir" operator setting via helm
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
ca-dir
setting in the configMap as mentioned in #6435 and #6091.