Document how to provide container registry credentials in air-gapped environment #7256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thbkrkr
reviewed
Oct 23, 2023
| @@ -53,6 +66,8 @@ The operator expects container images to be located at specific repositories in | |||
| * +my.registry/kibana/kibana:{version}+ | |||
| * +my.registry/apm/apm-server:{version}+ | |||
|
|
|||
| You can provide credentials to a custom repo by adding the imagePullSecrets parameter to your configuration as shown here - https://github.com/elastic/cloud-on-k8s/issues/2580#issuecomment-589602837 | |||
There was a problem hiding this comment.
We prefer to avoid the indirection to GitHub and simply put the information in the documentation.
Suggested change
| You can provide credentials to a custom repo by adding the imagePullSecrets parameter to your configuration as shown here - https://github.com/elastic/cloud-on-k8s/issues/2580#issuecomment-589602837 | |
| You can provide credentials to your private container registry by setting the `imagePullSecrets` field through the `spec.podTemplate` section of your Elastic resource specification, check <<{p}-customize-pods,how to customize the Elastic resources Pods>> and link:https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/[how to setup a Secret containing your registry credentials]. |
There was a problem hiding this comment.
Due to lack of activity, I applied the suggestion. I hope it is okay for you.
Adding information on how to use credentials with a custom repo. Added details to initial custom repo example also provided a link later on to another example in Github
thbkrkr
force-pushed
the
otteryoudoing-patch-1
branch
from
8a62257 to
adca8a4
Compare
thbkrkr
reviewed
Nov 13, 2023
thbkrkr
changed the title
robbavey
pushed a commit
to robbavey/cloud-on-k8s
that referenced
this pull request
Dec 20, 2023
…environment (elastic#7256) Co-authored-by: Thibault Richard <thb.krkr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding information on how to use credentials with a custom repo.
Added details to initial custom repo example.
Also provided a link later on to another example in Github.