Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eck-elasticsearch default secureSettings values to be slice. #7397

Conversation

naemono
Copy link
Contributor

@naemono naemono commented Dec 19, 2023

When installing/upgrading and setting secureSettings for the eck-elasticsearch Helm chart you get this warning:

❯ helm upgrade -i my-deployment elastic/eck-stack -n elastic --values values-initial.yaml
Release "my-deployment" does not exist. Installing it now.
coalesce.go:286: warning: cannot overwrite table with non table for eck-stack.eck-elasticsearch.secureSettings (map[])
NAME: my-deployment
LAST DEPLOYED: Tue Dec 19 10:17:24 2023

With these values:

eck-elasticsearch:
  fullnameOverride: elasticsearch01
  version: 8.11.1
  secureSettings:
    - secretName: gcs-credentials
  nodeSets:
  - name: master-data-nodes
    count: 3
    config:
      node.roles: ["master", "data", "ingest"]
    volumeClaimTemplates:
    - metadata:
        name: elasticsearch-data
      spec:
        accessModes:
        - ReadWriteOnce
        resources:
          requests:
            storage: 5Gi
        storageClassName: standard

This is because secureSettings is supposed to be an array/slice, not a map.

After this update, no error is seen

❯ helm upgrade -i my-deployment . -n elastic --values /path/to/values-initial.yaml
Release "my-deployment" does not exist. Installing it now.
NAME: my-deployment
LAST DEPLOYED: Tue Dec 19 10:28:20 2023
NAMESPACE: elastic
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
Elasticsearch ECK-Stack 0.9.0-SNAPSHOT has been deployed successfully!

Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
@naemono naemono merged commit 559c51e into elastic:main Dec 19, 2023
5 checks passed
@naemono naemono deleted the update-eck-elasticsearch-default-values-secure-settings branch December 19, 2023 17:08
robbavey pushed a commit to robbavey/cloud-on-k8s that referenced this pull request Dec 20, 2023
@pebrc pebrc added the sdh label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants