Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename resourceStatuses to details in StackConfigurationPolicy #7433

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Rename resourceStatuses to details in StackConfigurationPolicy #7433

merged 2 commits into from
Jan 3, 2024

Conversation

kvalliyurnatt
Copy link
Contributor

Renaming resourcesStatuses to details in the Stack config policy status to avoid conflicts during version upgrade from 2.10 to 2.11.

Tested this with upgrade and this resolves the issue that was observed earlier. Also ran the e2e tests and unit tests locally. Everything seems to work as expected.

@kvalliyurnatt kvalliyurnatt added >bug Something isn't working v2.11.0 labels Jan 2, 2024
naemono
naemono reviewed Jan 2, 2024
View reviewed changes
Copy link
Contributor

@naemono naemono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to update docs/orchestrating-elastic-stack-applications/stack-config-policy.asciidoc.

@naemono
Copy link
Contributor

naemono commented Jan 2, 2024

I think you also need to update docs/orchestrating-elastic-stack-applications/stack-config-policy.asciidoc.

Oh, and some things under hack/upgrade-test-harness.

@naemono
Copy link
Contributor

naemono commented Jan 2, 2024

Oh, and some things under hack/upgrade-test-harness.

Nevermind on this one, I'm wrong.

@thbkrkr thbkrkr added the exclude-from-release-notes Exclude this PR from appearing in the release notes label Jan 3, 2024
pebrc
pebrc approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@pebrc pebrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and fixed the issue in my test.

barkbay
barkbay approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

naemono
naemono approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@naemono naemono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here as well.

@kvalliyurnatt kvalliyurnatt merged commit 5779190 into elastic:main Jan 3, 2024
6 checks passed
@kvalliyurnatt kvalliyurnatt deleted the rename_scp_status branch January 3, 2024 14:12
@kvalliyurnatt kvalliyurnatt mentioned this pull request Jan 3, 2024
Merged
@kvalliyurnatt
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 2.11

Questions ?

Please refer to the Backport tool documentation

kvalliyurnatt added a commit to kvalliyurnatt/cloud-on-k8s that referenced this pull request Jan 3, 2024
@kvalliyurnatt
Rename resourceStatuses to details in StackConfigurationPolicy (elast…
0d72cb5 
…ic#7433)

* Rename resourceStatuses to details in StackConfigurationPolicy to avoid conflicts during upgrade

(cherry picked from commit 5779190)
kvalliyurnatt added a commit that referenced this pull request Jan 3, 2024
@kvalliyurnatt
Rename resourceStatuses to details in StackConfigurationPolicy (#7433) (
996f508 
#7435)

* Rename resourceStatuses to details in StackConfigurationPolicy to avoid conflicts during upgrade

(cherry picked from commit 5779190)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naemono naemono naemono approved these changes

@barkbay barkbay barkbay approved these changes

@pebrc pebrc pebrc approved these changes

@thbkrkr thbkrkr thbkrkr approved these changes

@rhr323 rhr323 Awaiting requested review from rhr323

Assignees
No one assigned
Labels
>bug Something isn't working exclude-from-release-notes Exclude this PR from appearing in the release notes v2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kvalliyurnatt @naemono @thbkrkr @pebrc @barkbay