Fix dry-run of helm charts during release. #7477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
naemono
added
>bug
thbkrkr
reviewed
Jan 17, 2024
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
thbkrkr
approved these changes
Jan 18, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
naemono
added a commit
to naemono/cloud-on-k8s
that referenced
this pull request
Jan 25, 2024
* Fix dry-run of helm charts during release. Signed-off-by: Michael Montgomery <mmontg1@gmail.com> (cherry picked from commit 3ab46dd)
naemono
added a commit
that referenced
this pull request
Jan 25, 2024
… recent Red Hat certificate api changes. (#7453) (#7502) * Fix dry-run of helm charts during release. (#7477) * Fix dry-run of helm charts during release. Signed-off-by: Michael Montgomery <mmontg1@gmail.com> (cherry picked from commit 3ab46dd) * Fix recent Red Hat certificate api changes. (#7453) * Fix recent Red Hat certificate api changes. --------- Signed-off-by: Michael Montgomery <mmontg1@gmail.com> (cherry picked from commit 4c42813)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen multiple issues in this area: #6953, #7045
It appears we can't pass environment variables when uploading buildkite pipelines. This explicitly sets the
dry-runflag tofalseduring the release pipeline.