Remove secure settings field from SCP example #7493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naemono
reviewed
Jan 22, 2024
Comment on lines
-108
to
-109
| secureSettings: | ||
| - secretName: oidc-secret |
There was a problem hiding this comment.
Do we have a preference for removing this vs noting that this is deprecated, but still "technically valid"?
There was a problem hiding this comment.
In this case I want to remove it, because we are setting it twice in this example. That is confusing.
naemono
approved these changes
Jan 22, 2024
Comment on lines
-108
to
-109
| secureSettings: | ||
| - secretName: oidc-secret |
barkbay
approved these changes
Jan 23, 2024
kvalliyurnatt
added a commit
to kvalliyurnatt/cloud-on-k8s
that referenced
this pull request
Jan 23, 2024
We no longer encourage users to use the old secureSettings field in Stack configuration policy, instead we expect the users to use the secureSettings field under the elasticsearch or kibana fields. Fixing documentation where the example had both secureSettings fields are set . (cherry picked from commit 6694d0c)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
kvalliyurnatt
added a commit
that referenced
this pull request
Jan 23, 2024
# Backport This will backport the following commits from `main` to `2.11`: - [Remove secure settings field from SCP example (#7493)](#7493) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer encourage users to use the old secureSettings field in Stack configuration policy, instead we expect the users to use the secureSettings field under the elasticsearch or kibana fields. Fixing documentation where the example had both secureSettings field set .