-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase the default PVC size for logstash #7540
Merged
barkbay
merged 9 commits into
elastic:main
from
kaisecheng:logstash_increase_default_pv_size
Feb 9, 2024
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c934b7a
Increase the default PVC size for logstash
kaisecheng f3d0c9c
update unit tests
kaisecheng 23f25aa
update doc
kaisecheng 9bbf3fa
Update docs/orchestrating-elastic-stack-applications/logstash.asciidoc
kaisecheng b1e09c9
Update docs/orchestrating-elastic-stack-applications/logstash.asciidoc
kaisecheng 9caa231
Update docs/orchestrating-elastic-stack-applications/logstash.asciidoc
kaisecheng 3536e39
Update docs/orchestrating-elastic-stack-applications/logstash.asciidoc
kaisecheng b8671c0
Update docs/orchestrating-elastic-stack-applications/logstash.asciidoc
kaisecheng 43cd3e0
Update pkg/controller/logstash/volume/defaults.go
kaisecheng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be a good idea to add extra information on using persistent volumes, something like:
In particular, when enabling the persistent queue feature, using dead letter queues, or certain plugins that make heavy use of temporary storage, the default volume size will likely be insufficient for production workloads and you should increase the storage capacity, or consider creating separate volumes for these use cases.
Maybe just before the
Separate storage
section?