-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support loadBalancerClass in service reconciliation #7706
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also wondering if we should not also update applyServerSideValues
for ExternalTrafficPolicy
and AllocateLoadBalancerNodePorts
, I think needsUpdate(...)
always returns true
on my test cluster with the following diff:
v1.ServiceSpec{
... // 8 identical fields
LoadBalancerSourceRanges: nil,
ExternalName: "",
- ExternalTrafficPolicy: "",
+ ExternalTrafficPolicy: "Cluster",
HealthCheckNodePort: 0,
PublishNotReadyAddresses: false,
SessionAffinityConfig: nil,
IPFamilies: {"IPv4"},
IPFamilyPolicy: &"SingleStack",
- AllocateLoadBalancerNodePorts: nil,
+ AllocateLoadBalancerNodePorts: &true,
LoadBalancerClass: &"foo",
InternalTrafficPolicy: &"Cluster",
}
I think that's a good idea. I will add it to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #7691
From the k8s docs:
AWS EKS uses this field on EKS clusters > 1.24 that have upgraded to the new AWS LoadBalancer Controller
Behaviour this PR should implement:
loadBalancerClass
from the server side values if no value is set in the ECK service spectype
of the service is no longerLoadBalancer