-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECK Enterprise Search Helm Chart. #7744
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Rename file. Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
pebrc
added
triage
and removed
>enhancement
Enhancement of existing functionality
labels
Apr 24, 2024
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Add basic install manifest Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
naemono
requested review from
thbkrkr,
pebrc,
barkbay,
rhr323 and
kvalliyurnatt
April 24, 2024 19:06
naemono
changed the title
WIP: ECK Enterprise Search Helm Chart.
ECK Enterprise Search Helm Chart.
Apr 24, 2024
pebrc
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
deploy/eck-stack/examples/enterprise-search/with-custom-configuration.yaml
Outdated
Show resolved
Hide resolved
deploy/eck-stack/charts/eck-enterprise-search/templates/enterprisesearch.yaml
Outdated
Show resolved
Hide resolved
deploy/eck-stack/charts/eck-enterprise-search/examples/with-custom-configuration.yaml
Show resolved
Hide resolved
thbkrkr
approved these changes
Apr 25, 2024
deploy/eck-stack/charts/eck-enterprise-search/templates/enterprisesearch.yaml
Show resolved
Hide resolved
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
This adds an ECK EnterpriseSearch Helm Chart for deploying Enterprise Search instances using the ECK Operator.
Testing
Installing with stack version
8.13.2
seems to work without issues (snapshot versions aren't quite working)Everything becomes healthy:
All components green
Required
elasticsearchRef
orconfigRef
works: (i tried all variations of this from values commented out, to just being empty for one/both)Enterprise Search integration with Kibana seems to work:
TODO: