Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct statefulset name label for Logstash pods #7788

Merged
merged 1 commit into from
May 14, 2024
Merged

Correct statefulset name label for Logstash pods #7788

merged 1 commit into from
May 14, 2024

Conversation

kaisecheng
Copy link
Contributor

Corrected Logstash label logstash.k8s.elastic.co/statefulset-name to include the -ls suffix, fixing issue preventing pod recreation during ECK upgrade from version 2.11 to 2.12.

#7587 patched Logstash statefulset label, however, the patched label missed -ls suffix.

Relates: #7587
Fixes: #7742

@kaisecheng
Corrected Logstash label logstash.k8s.elastic.co/statefulset-name to …
4ab7884 
…include the -ls suffix, fixing issues preventing pod recreation during ECK upgrade from version 2.11 to 2.12.

Fixes: elastic#7742
@kaisecheng kaisecheng self-assigned this May 9, 2024
@botelastic botelastic bot added the triage label May 9, 2024
@kaisecheng kaisecheng added the >bug Something isn't working label May 9, 2024
@botelastic botelastic bot removed the triage label May 9, 2024
@kaisecheng kaisecheng requested a review from thbkrkr May 9, 2024 16:13
@kaisecheng
Copy link
Contributor Author

@pebrc @thbkrkr I believe this fix the issue that Logstash pod unable to recreate during ECK upgrade

@kaisecheng kaisecheng requested a review from pebrc May 9, 2024 16:35
robbavey
robbavey approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvalliyurnatt kvalliyurnatt merged commit 09e75f8 into elastic:main May 14, 2024
5 checks passed
kvalliyurnatt pushed a commit to kvalliyurnatt/cloud-on-k8s that referenced this pull request May 14, 2024
@kaisecheng
Corrected Logstash label logstash.k8s.elastic.co/statefulset-name to …
58bf1f1 
…include the -ls suffix, fixing issues preventing pod recreation during ECK upgrade from version 2.11 to 2.12. (elastic#7788)

Fixes: elastic#7742
(cherry picked from commit 09e75f8)
@kvalliyurnatt kvalliyurnatt mentioned this pull request May 14, 2024
Merged
@kvalliyurnatt
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 2.13

Questions ?

Please refer to the Backport tool documentation

kvalliyurnatt added a commit that referenced this pull request May 14, 2024
@kvalliyurnatt @kaisecheng
Corrected Logstash label logstash.k8s.elastic.co/statefulset-name to …
6404bcb 
…include the -ls suffix, fixing issues preventing pod recreation during ECK upgrade from version 2.11 to 2.12. (#7788) (#7812)

Fixes: #7742
(cherry picked from commit 09e75f8)

Co-authored-by: kaisecheng <69120390+kaisecheng@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbavey robbavey robbavey approved these changes

@pebrc pebrc pebrc approved these changes

@thbkrkr thbkrkr Awaiting requested review from thbkrkr

Assignees

@kaisecheng kaisecheng

Labels
>bug Something isn't working :logstash v2.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logstash StatefulSet initContainers command is not properly reconciliated
4 participants
@kaisecheng @kvalliyurnatt @pebrc @robbavey