Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for Logstash memory in resource aggregator #7853

Merged
merged 2 commits into from
May 28, 2024

Conversation

pebrc
Copy link
Collaborator

@pebrc pebrc commented May 27, 2024

Logstash resources should be counted towards the ECK managed memory and ERU usage.

@pebrc pebrc added the v2.13.0 label May 27, 2024
@botelastic botelastic bot added the triage label May 27, 2024
@pebrc pebrc added >enhancement Enhancement of existing functionality and removed triage labels May 27, 2024
@pebrc pebrc requested review from thbkrkr and robbavey May 27, 2024 14:59
Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test should be fixed, LGTM otherwise.

pkg/license/testdata/stack.yaml Outdated Show resolved Hide resolved
pkg/license/testdata/stack.yaml Outdated Show resolved Hide resolved
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pebrc pebrc merged commit 5be7250 into elastic:main May 28, 2024
5 checks passed
pebrc added a commit to pebrc/cloud-on-k8s that referenced this pull request May 28, 2024
Logstash resources should be counted towards the ECK managed memory and ERU usage.

(cherry picked from commit 5be7250)
@pebrc
Copy link
Collaborator Author

pebrc commented May 28, 2024

💚 All backports created successfully

Status Branch Result
2.13

Questions ?

Please refer to the Backport tool documentation

pebrc added a commit that referenced this pull request May 28, 2024
Logstash resources should be counted towards the ECK managed memory and ERU usage.

(cherry picked from commit 5be7250)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Enhancement of existing functionality v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants