Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module github.com/prometheus/client_golang to v1.20.5 #8133

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

elastic-renovate-prod[bot]
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
github.com/prometheus/client_golang require patch v1.20.4 -> v1.20.5

Release Notes

prometheus/client_golang (github.com/prometheus/client_golang)

v1.20.5: / 2024-10-15

Compare Source

We decided to revert the testutil change that made our util functions less error-prone, but created a lot of work for our downstream users. Apologies for the pain! This revert should not cause any major breaking change, even if you already did the work--unless you depend on the exact error message.

Going forward, we plan to reinforce our release testing strategy [1],[2] and deliver an enhanced testutil package/module with more flexible and safer APIs.

Thanks to @​dashpole @​dgrisonnet @​kakkoyun @​ArthurSens @​vesari @​logicalhan @​krajorama @​bwplotka who helped in this patch release! 🤗

Changelog

[BUGFIX] testutil: Reverted #​1424; functions using compareMetricFamilies are (again) only failing if filtered metricNames are in the expected input. #​1645


Configuration

📅 Schedule: Branch creation - "after 1am on monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@elastic-renovate-prod elastic-renovate-prod bot added the >renovate PRs created by or relating to Renovate label Oct 21, 2024
@thbkrkr
Copy link
Contributor

thbkrkr commented Oct 22, 2024

buildkite test this

@thbkrkr thbkrkr enabled auto-merge (squash) October 22, 2024 09:53
@elastic-renovate-prod
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@thbkrkr thbkrkr merged commit 9c8cca4 into main Oct 22, 2024
5 checks passed
@thbkrkr thbkrkr deleted the renovate/gh.neting.cc-prometheus-client_golang-1.x branch October 22, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>renovate PRs created by or relating to Renovate v2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant