Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resetting service type to default when not specified #8165

Merged
merged 13 commits into from
Oct 31, 2024
Merged

Fix resetting service type to default when not specified #8165

merged 13 commits into from
Oct 31, 2024

Commits on Oct 29, 2024

  1. Unit test verifying that the external service has the default cluster… 

    …IP type
    @thbkrkr
    thbkrkr committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    32fe7f9 View commit details
    Browse the repository at this point in the history

  2. Update NewExternalService with default ClusterIP if type not set

    @thbkrkr
    thbkrkr committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    5b63694 View commit details
    Browse the repository at this point in the history

  3. Unit test verifying that a services needs to be recreated to go from … 

    …LoadBalancer type to ClusterIP
    @thbkrkr
    thbkrkr committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    d692c82 View commit details
    Browse the repository at this point in the history

  4. Shortcut applyServerSideValues when the service type has changed

    @thbkrkr
    thbkrkr committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    d95f488 View commit details
    Browse the repository at this point in the history

  5. Skip reconciliation if resource is being deleted

    @thbkrkr
    thbkrkr committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    1dbb757 View commit details
    Browse the repository at this point in the history

  6. Check being deleted only after deleting

    @thbkrkr
    thbkrkr committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    0d3a897 View commit details
    Browse the repository at this point in the history

  7. Revert explicit check on type to recreate when type changes

    @thbkrkr
    thbkrkr committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    d38519e View commit details
    Browse the repository at this point in the history

  8. Update unit tests with default ClusterIP value

    @thbkrkr
    thbkrkr committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4a9aac0 View commit details
    Browse the repository at this point in the history

  9. nit: reuse svc and move

    @thbkrkr
    thbkrkr committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    ecaf23e View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Revert being deleted detection in favor of handling AlreadyExists err… 

    …or at the caller level
    @thbkrkr
    thbkrkr committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    0218fd6 View commit details
    Browse the repository at this point in the history

  2. skip applyServerSideValues if the service type changes from something… 

    … different to the default ClusterIP value
    @thbkrkr
    thbkrkr committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    79a182d View commit details
    Browse the repository at this point in the history

  3. Better message after requeuing for external service reconciliation

    @thbkrkr
    thbkrkr committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    f320dcc View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Merge branch 'main' into fix-reset-service-type

    @thbkrkr
    thbkrkr authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    c2acb4b View commit details
    Browse the repository at this point in the history