Ensure Elasticsearch client is closed after each reconciliation #8175
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
naemono
requested review from
thbkrkr,
pebrc,
barkbay,
rhr323 and
kvalliyurnatt
pebrc
reviewed
Nov 4, 2024
pebrc
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Great finding. I am still a bit confused how this slipped through. I think you have to adjust the fake client too to not panic when close is called
github.com/elastic/cloud-on-k8s/v2/pkg/controller/autoscaling/elasticsearch.(*fakeEsClient).Close(0xc00095c700?)
Add close func to fake esclient struct. Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
pebrc
approved these changes
Nov 4, 2024
|
Signs from initial testing of the latest build show good signs, as the memory seems stable. I'm going to let it run the rest of the day to ensure before merging. |
|
Ok, you can see where I configured with the new version, and it's been a straight line of heap consumption at this point. I'm going to go ahead and merge this, and create a backport. |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
naemono
added a commit
to naemono/cloud-on-k8s
that referenced
this pull request
Nov 4, 2024
* Ensure esclient is closed after each reconcile. * Also call close in stackconfigpolicy. * Add close func to fake esclient struct. * Also add close to fakeseClient in stackconfigpolicy --------- Signed-off-by: Michael Montgomery <mmontg1@gmail.com> (cherry picked from commit 602866e)
naemono
added a commit
that referenced
this pull request
Nov 4, 2024
* Ensure esclient is closed after each reconcile. * Also call close in stackconfigpolicy. * Add close func to fake esclient struct. * Also add close to fakeseClient in stackconfigpolicy --------- Signed-off-by: Michael Montgomery <mmontg1@gmail.com> (cherry picked from commit 602866e)
rhr323
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8174
While investigating #8174 a couple pprof heap dumps were taken over the course of a couple of days, and compared using the diff capabilities of pprof:
This brought to light the following function in the autoscaling controller (
attemptOnlineReconciliation), which seems to have had it's heap allocations grow by about %2000 since the first dump:Upon further investigation, we don't appear to be closing idle connections in the underlying http client, which could be leaking goroutines, and therefore leading to this memory increase.