Add recommened roles for Elastic Agent on Kubernetes #8188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pebrc
force-pushed
the
8168-missing-roles
branch
from
d748b58 to
5031542
Compare
barkbay
approved these changes
Nov 12, 2024
|
buildkite test this -f p=gke,s=8.16.0,E2E_TAGS=agent |
|
buildkite test this -f p=gke,s=8.16.0,E2E_TAGS=agent |
|
buildkite test this -f p=gke,s=8.16.0,E2E_TAGS=agent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8168
I tried to amend the roles based on https://raw.githubusercontent.com/elastic/elastic-agent/v8.15.3/deploy/kubernetes/elastic-agent-standalone-kubernetes.yaml
I left out the cloudbeat recommendations, because I think we cannot cater for all integrations in the defaults.
But we can also go for a the maximal set of permissions, to avoid problems and allow scurity conscious users to trim them down to what is necessary for them.
It is problematic that we need to update ~ 4 places and effectively duplicate the roles that the Elastic Agent team defines without having a good process to update them when the source of truth changes.