Transform dynamic watches integration tests into unit tests #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit sets up a unit test to cover the integration test scenario we had for the DynamicEnqueueRequest handler. A very basic integration test is left to ensure everything correctly fits together, but most of the logic we wanted to test (and a bit more) is moved into the unit test. Main benefits: * remove complexity from IT complexity (edge cases of 1-2 potential reconciliations, wait for something to not happen) * remove dependency to test.Timeout in most tests (used both in `CheckReconcileCalledIn` and `CheckReconcileNotCalledWithin`) * faster execution time
sebgl
requested review from
artemnikitin,
barkbay,
idanmo,
nkvoll,
pebrc and
thbkrkr
as code owners
sebgl
commented
May 23, 2019
|
|
||
| // StartManager sets up a manager and controller to perform reconciliations in background. | ||
| // It must be stopped by calling the returned function. | ||
| func StartManager(t *testing.T, addToMgrFunc func(manager.Manager, operator.Parameters) error, parameters operator.Parameters) (k8s.Client, func()) { |
sebgl
changed the title
sebgl
changed the title
pebrc
approved these changes
May 23, 2019
|
jenkins test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit sets up a unit test to cover the integration test scenario
we had for the DynamicEnqueueRequest handler. A very basic integration
test is left to ensure everything correctly fits together, but most of
the logic we wanted to test (and a bit more) is moved into the unit test.
Main benefits:
wait for something to not happen)
CheckReconcileCalledInandCheckReconcileNotCalledWithin)Fixes #908.