Move Kibana configuration in a Secret #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thbkrkr
requested review from
artemnikitin,
barkbay,
idanmo,
nkvoll,
pebrc and
sebgl
as code owners
thbkrkr
force-pushed
the
mv-kibana-config-in-a-secret-volume
branch
from
7601ff5 to
4594c49
Compare
thbkrkr
commented
Jun 3, 2019
thbkrkr
commented
Jun 3, 2019
pebrc
reviewed
Jun 5, 2019
operators/pkg/controller/elasticsearch/settings/canonical_config.go
Outdated
Show resolved
Hide resolved
operators/pkg/controller/elasticsearch/mutation/comparison/config.go
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the Kibana configuration directory in a Secret mounted as a Volume in each pod of the Kibana deployment.
kibana.ymlconfig settings file (named<name>-kb-config)commonpackage)Fixes #946.