Remove default discovery service #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is no longer required for discovery, which is now file based.
nkvoll
requested review from
artemnikitin,
barkbay,
idanmo,
pebrc,
sebgl and
thbkrkr
as code owners
pebrc
approved these changes
Jun 5, 2019
| }); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| // reconcileAllRemoteClusters creates a reconcile request for each currently existing remote cluster resource. | ||
| func reconcileAllRemoteClusters(c k8s.Client) handler.ToRequestsFunc { | ||
| func allRemoteClustersWithMatchingSeedServiceMapper(c k8s.Client) handler.Mapper { |
There was a problem hiding this comment.
This is a long function name!
nkvoll
force-pushed
the
remove-default-discovery-service
branch
from
a3934d6 to
3c8d0e6
Compare
nkvoll
force-pushed
the
remove-default-discovery-service
branch
from
3c8d0e6 to
33123a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaves remote clusters in a working state by reconciling a
{remote}-es-remote-cluster-seedService in the remote namespace so we have something to give to Elasticsearch throughseed_hosts.Since we cannot set owners across namespaces, and this same service could be used by multiple remote clusters, we have to deal with its lifecycle a bit differently: