Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go and tooling dependencies. #431

Merged
merged 7 commits into from
Apr 5, 2023
Merged

Update go and tooling dependencies. #431

merged 7 commits into from
Apr 5, 2023

Conversation

gigerdo
Copy link
Member

@gigerdo gigerdo commented Mar 31, 2023 •
edited
Loading

Some of the commands aren't working anymore when using newer go versions. So this PR updates a bunch of dependencies:

  • Go to 1.19 (same as our other Go projects)
  • Tooling dependencies to their latest version
  • Update a few go dependencies (Those where the bot has upgrade PRs open)
    • go-openapi update will have to be done separately, it breaks unit tests
  • Replace deprecated usages due to new go version

Description

Related Issues

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@gigerdo gigerdo changed the title Update dependencies. Update go and tooling dependencies. Mar 31, 2023
@gigerdo gigerdo marked this pull request as ready for review March 31, 2023 13:52
@gigerdo gigerdo requested a review from a team as a code owner March 31, 2023 13:52
mieciu
mieciu approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@mieciu mieciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gigerdo gigerdo merged commit bfd8ba4 into elastic:master Apr 5, 2023
@gigerdo gigerdo deleted the update-versions branch April 5, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mieciu mieciu mieciu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gigerdo @mieciu