Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ms-89 update #436

Merged
merged 1 commit into from
Apr 5, 2023
Merged

ms-89 update #436

merged 1 commit into from
Apr 5, 2023

Conversation

mieciu
Copy link
Contributor

@mieciu mieciu commented Apr 5, 2023 •
edited
Loading

Description

Related Issues

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@mieciu mieciu closed this Apr 5, 2023
@elastic elastic deleted a comment from cla-checker-service bot Apr 5, 2023
@mieciu mieciu reopened this Apr 5, 2023
@cla-checker-service
Copy link

cla-checker-service bot commented Apr 5, 2023 •
edited
Loading

💚 CLA has been signed

@mieciu mieciu marked this pull request as ready for review April 5, 2023 12:46
@mieciu mieciu requested a review from a team as a code owner April 5, 2023 12:46
gigerdo
gigerdo approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@gigerdo gigerdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mieciu mieciu merged commit 94a81b6 into elastic:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigerdo gigerdo gigerdo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mieciu @gigerdo