Add context to calls that create SearchDeploymentsParams #482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I saw missing from our usage of the cloud-sdk.
Description
Adds a proper context object to API functions that create
SearchDeploymentsParams
structs.Motivation and Context
Adding a context to http calls is considered best practice in Go.
How Has This Been Tested?
I haven't tested this but I don't think more coverage is needed as the default case (no context) will behave the same and if a context is provided, it will be passed to the http client.
Types of Changes
Readiness Checklist