Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor improvements to version bump workflow #1964

Merged
merged 5 commits into from
Mar 31, 2024
Merged

minor improvements to version bump workflow #1964

merged 5 commits into from
Mar 31, 2024

Conversation

orouz
Copy link
Collaborator

@orouz orouz commented Feb 19, 2024 •
edited
Loading

  • cleaned up code, renamed some variables for consistency, moved some lines
  • added label creation for mergify
  • added workflow summary with links to PRs

PR for release docs (https://github.com/elastic/security-team/pull/8552)

@mergify Mergify
Copy link

mergify bot commented Feb 19, 2024

This pull request does not have a backport label. Could you fix it @orouz? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot assigned orouz Feb 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2024 •
edited
Loading

❌ No tests were run ❌

@orouz orouz force-pushed the version_ci_iter branch 2 times, most recently from 295370a to 4192db7 Compare March 7, 2024 13:33
@orouz orouz marked this pull request as ready for review March 7, 2024 14:35
@orouz orouz requested a review from a team as a code owner March 7, 2024 14:35
gurevichdmitry
gurevichdmitry approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@gurevichdmitry gurevichdmitry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orouz
Copy link
Collaborator Author

orouz commented Mar 14, 2024 •
edited
Loading

going to wait for #2012 which adds some utility functions i want to re-use in this workflow

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 31, 2024 •
edited
Loading

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 359
⬜ Skipped 33

@orouz orouz enabled auto-merge (squash) March 31, 2024 14:11
@orouz orouz merged commit 9d088d6 into elastic:main Mar 31, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurevichdmitry gurevichdmitry gurevichdmitry approved these changes

Assignees

@orouz orouz

Labels
backport-skip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orouz @gurevichdmitry