-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Asset Inventory][AWS & Azure] Support organization account deployment type #2591
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label. Could you fix it @kubasobon? 🙏
|
@@ -0,0 +1,444 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't arm for Azure? I had understood this PR is for AWS only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment actually goes for this whole folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the description and title. Azure needed me to just clone the ARM templates.
@@ -0,0 +1,209 @@ | |||
// Licensed to Elasticsearch B.V. under one or more contributor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I understand correctly that running this will directly start a new stack?
Is this dev only? That's not how we use on pro, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is a copy of CSPM devtools. Just like we have just deploy-cloudformation
, we now get just deploy-asset-inventory-cloudformation
. Not used in CI, just by developers.
|
||
const ( | ||
rootRole = "cloudbeat-asset-inventory-root" | ||
memberRole = "cloudbeat-asset-inventory-securityaudit" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this role expected to be created by the cloud formation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. If account_type
is set to organization-account
we assume the deployment was done via updated CloudFormation or the proper roles have been created manually. Either way, we assume the roles are there.
@romulets Please take another look |
Summary of your changes
AWS: Clones CloudFormation templates for Asset Inventory and enables it to work in Organization mode.
Azure: Clones ARM templates.
Screenshot/Data
Kibana showing data from multiple accounts in the organization; Please note the absence of "Sandbox" account from "test-organization" OU
Related Issues
Fixes https://github.com/elastic/security-team/issues/10606
Checklist