Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move launcher errors under launcher package #628

Merged
merged 4 commits into from
Jan 3, 2023

Conversation

amirbenun
Copy link
Contributor

What does this PR do?
Moving launcher errors to be defined on the same package as the launcher.
The motivation behind maintaining the two on the same package is that the launcher already has the errors as a dependency. The launcher can report a different status to the fleet based on the returned error. Which means, the errors better be defined on the same package.

Related Issues

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

@amirbenun amirbenun requested a review from a team as a code owner January 2, 2023 14:18
@mergify
Copy link

mergify bot commented Jan 2, 2023

This pull request does not have a backport label. Could you fix it @amirbenun? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

launcher/launcher.go Outdated Show resolved Hide resolved
amirbenun and others added 3 commits January 3, 2023 10:51
typo

Co-authored-by: Uri Weisman <68195305+uri-weisman@users.noreply.github.com>
@amirbenun amirbenun merged commit 52bf243 into elastic:main Jan 3, 2023
@amirbenun amirbenun deleted the launcher_package_errors branch January 3, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants