Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock 7.12 rule versions #1083

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Conversation

brokensound77
Copy link
Contributor

Issues

None

Summary

lock versions for 7.12 rules

To reconcile, the promotion rules needed to have a version bump and the event_override field added (ref: #1082)

Details

 python -m detection_rules dev kibana-diff -b 7.12 -t 100

Downloading rules from elastic/kibana 7.12 branch in kibana repo using 100 threads ...
{
  "diff": [],
  "missing_from_kibana": [],
  "missing_from_repo": [],
  "stats": {
    "diff": 0,
    "missing_from_kibana": 0,
    "missing_from_repo": 0,
    "total_gh_prod_rules": 546,
    "total_repo_prod_rules": 546
  }
}

@brokensound77 brokensound77 added the v7.12.0 7.12 rules release package label Apr 6, 2021
@brokensound77 brokensound77 requested a review from rw-access April 6, 2021 16:41
Copy link
Contributor

@rw-access rw-access left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

Copy link
Contributor

@rw-access rw-access left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I change my mind. I see brand new entries in the version lock. that's odd right?

@brokensound77 brokensound77 merged commit 92313b4 into elastic:7.12 Apr 6, 2021
@brokensound77 brokensound77 deleted the lock-7.12-versions branch April 6, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v7.12.0 7.12 rules release package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants