[Rule Tuning] Increase lookback for endpoint rules #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brokensound77
added
Rule: Tuning
rw-access
approved these changes
Aug 21, 2020
spong
approved these changes
Aug 21, 2020
There was a problem hiding this comment.
+1 on padding an extra minute here (over the 2+1 minimum) for a total lookback of 4min -- LGTM! 👍 Thanks @brokensound77!
bm11100
approved these changes
Aug 21, 2020
This was referenced Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
resolves #199
Summary
Increases the lookback on all rules targeting the
logs.endpoint.events.*index by 3 minutes each. All of these rules were using the defaults (not set locally, which infers defaults from API):interval = "5m"from = "now-6m"This changes the rules to
from = "now-9m"