-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Rule] Elastic Endpoint and External Alerts #42
Conversation
rule_name_override = "message" | ||
severity = "medium" | ||
tags = ["Elastic"] | ||
timestamp_override = "event.ingested" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to override the timestamp here since event.ingested
might not be filled in for most external alerts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when a timestamp override is defined and missing, does it default back to @timestamp
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, will need to add to signal metadata so the user knows this happened.
For the folder layout, I think we can rename the |
investigating external alerts in the app. | ||
""" | ||
language = "kuery" | ||
license = "Elastic License" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add max_signals = unbounded
(and support for unbounded 😉 )
Co-authored-by: Ross Wolf <31489089+rw-access@users.noreply.github.com>
Co-authored-by: Justin Ibarra <brokensound77@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if we can make logs-*
more precise
|
||
|
||
[[rule.risk_score_mapping]] | ||
field = "event.risk_score" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to use event.risk_score_norm
here, but I'm not quite sure the endpoint is populate that field as well. Will verify during testing.
I've asked internally for what we could refine this further to. Will leave the comment above unresolved for reference/tracking. |
Issues
Resolves #41
Summary
In support of elastic/kibana#65942 to create two new pre-packaged rules that will enable
Elastic Endpoint Alerts
andExternal Alerts
to be used in investigations.This also includes updates to
schema.py
for the new fields added to therules_schema
as part of elastic/kibana#70288. These new fields include:Note:
risk_score_mapping
andseverity_mapping
are subject to change depending on the desired implementation.Contributor checklist