Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for threat match rule type #694

Closed
wants to merge 2 commits into from
Closed

Add support for threat match rule type #694

wants to merge 2 commits into from

Conversation

brokensound77
Copy link
Contributor

@brokensound77 brokensound77 commented Dec 7, 2020 •
edited
Loading

Issues

Resolves #305
Related to # elastic/elasticsearch#64746

Summary

Adds support for threat_match rules.

TODO

  • verify fields/schema
  • add support to CLI rule builder (plus read list from file)
  • check for opportunities/needs to add unit test and/or validate fields

@brokensound77 brokensound77 added cli command line tooling python Internal python for the repository labels Dec 7, 2020
@rw-access
Copy link
Contributor

@brokensound77 can we close this, since it was done in #1138?

@brokensound77
Copy link
Contributor Author

I'll leave it until CLI support is added. Hopefully should get to that this week.

@brokensound77
Copy link
Contributor Author

I'll leave it until CLI support is added. Hopefully should get to that this week.

disregard - replied on mobile and thought this was the issue - closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikaayenson Mikaayenson Awaiting requested review from Mikaayenson Mikaayenson will be requested when the pull request is marked ready for review Mikaayenson is a code owner

@eric-forte-elastic eric-forte-elastic Awaiting requested review from eric-forte-elastic eric-forte-elastic will be requested when the pull request is marked ready for review eric-forte-elastic is a code owner

@terrancedejesus terrancedejesus Awaiting requested review from terrancedejesus terrancedejesus will be requested when the pull request is marked ready for review terrancedejesus is a code owner

Assignees
No one assigned
Labels
cli command line tooling python Internal python for the repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for threat match rules
2 participants
@brokensound77 @rw-access