-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for collapsible sections #1279
Comments
Adding the #team-discuss label as I want to gauge interest in this feature and see if anyone has other workarounds. |
@jrodewig +1 for collapsible sections. In Kibana, we can use them for breaking changes, and also for examples. |
APM doesn't have a specific use case, but it's a welcome enhancement. |
@jrodewig I have been using collapsible sections (also called "Zippies") in my previous job. It's a great solution to enhance navigation and discoverability in general. It would be nice to see it implemented in our doc. Happy to contribute! |
Since @nik9000 migrated our docbooks to direct HTML (thanks again Nik!), we can now use the html passthrough method (option 2). Here's a proof of concept I worked up using a section of the Elasticsearch 8.0 breaking changes: |
I think collapsible would be nicer though! I can probably make that work. |
Thanks @jrodewig - I tried playing with. The |
@benskelker Good to know. It looks like there are several polyfills for IE/Edge, but none of those are easily implemented via HTML itself. It seems like implementing this through Asciidoctor is preferable. |
It turns out that Asciidoctor just uses |
This adds support for collapsible examples to our docs. It turns out that asciidoctor just uses `<details>` and `<summary>` which isn't supported by all browsers, but we've got a polyfill. Closes elastic#1279
This adds support for collapsible examples to our docs. It turns out that asciidoctor just uses `<details>` and `<summary>` which isn't supported by all browsers, but we've got a polyfill. Closes #1279
To improve our breaking changes documentation, the Elasticsearch writers would like to use collapsible sections in our HTML output.
As of writing, it doesn't appear this is supported. I've documented my attempts to implement collapsible sections below.
Option 1: Use the Asciidoctor
[%collapsible]
blockI first tried to use the
[%collapsible]
block added in Asciidoctor 2.0:However, our docs build uses Asciidoctor 1.5 which doesn't support this block type.
Option 2: Use an html passthrough
I then tried to use passthrough blocks to use HTML details and summary tags.
However, docbook doesn't allow us to pass these HTML elements on directly. After looking at the docbook DTD, I don't believe any collapsible elements are supported.
The text was updated successfully, but these errors were encountered: