Add the option to skip docbook for single page #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the option to generate html directly from asciidoctor for single page books with `--direct_html`. Right now no books use this but we'd like to migrate all of them too it once we're sure the output looks good for them! Relates to elastic#743
nik9000
commented
Nov 8, 2019
| @@ -206,27 +208,7 @@ sub build_single { | |||
| $raw_dest->mkpath; | |||
| } | |||
|
|
|||
| my %xsltopts = ( | |||
There was a problem hiding this comment.
Moved next to the xslt invocation.
| my ( $output, $died ); | ||
| my $dest_xml = $index->basename; |
There was a problem hiding this comment.
Moved into the branch that deals with the xml.
| @@ -267,25 +254,47 @@ sub build_single { | |||
| } or do { $output = $@; $died = 1; }; | |||
| _check_build_error( $output, $died, $lenient ); | |||
|
|
|||
| if ( !$lenient ) { | |||
| unless ( $direct_html ) { | |||
There was a problem hiding this comment.
Everything in here is either moved from above or the same as it was before, just indented one more time.
| @@ -52,7 +52,6 @@ module.exports = templateSource => { | |||
| * at the end of the chunk in case the marker is on the edge. */ | |||
| const slice = Math.max(0, chunk.length - preserve); | |||
| chunk = chunk.slice(slice) + result.value; | |||
| // TODO check if slice + keeps a copy of internal memory. This implementation assumes it *doesn't* | |||
There was a problem hiding this comment.
I checked this while debugging the failure below.
| @@ -189,7 +193,8 @@ module.exports = templateSource => { | |||
| const out = apply(raw[Symbol.asyncIterator](), lang, initialJsState); | |||
| write.on("close", resolve); | |||
| write.on("error", reject); | |||
| out.on("error", write.destroy); | |||
| // out.on("error", write.destroy) doesn't properly forward the error! | |||
| out.on("error", err => write.destroy(err)); | |||
There was a problem hiding this comment.
I have no idea why this is required. Maybe destroy is altered once you start the pipe or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to generate html directly from asciidoctor for
single page books with
--direct_html. Right now no books use this butwe'd like to migrate all of them too it once we're sure the output looks
good for them!
Relates to #743