Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move legacy APM books back to /en/apm/* #2324

Merged
merged 3 commits into from
Dec 21, 2021

Conversation

bmorelli25
Copy link
Member

Amends #2309 by moving legacy APM books back to /en/apm/*.

@bmorelli25 bmorelli25 requested a review from gtback December 16, 2021 22:03
@bmorelli25 bmorelli25 self-assigned this Dec 16, 2021
@gtback
Copy link
Member

gtback commented Dec 16, 2021

We can see what this looks like, but I was thinking it might be easier to just manually add en/apm prefix on lines 2300/2303 and 2316/2319. As it is, this is likely to break things, since the page https://www.elastic.co/guide/en/apm/index.html can't come from two different sections.

@gtback
Copy link
Member

gtback commented Dec 16, 2021

Or, honestly, we could move the books back up into the APM section (on that same page linked above), but have a subsection on that page (maybe?)

@bmorelli25
Copy link
Member Author

Or, honestly, we could move the books back up into the APM section (on that same page linked above), but have a subsection on that page (maybe?)

That's a reaaaaaally interesting idea. A legacy section within that subsection would probably make more sense for our users anyways since they're more likely to look in the APM section for these docs.

Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming the diff shows what we expect. We can clean up the "new" "legacy" docs at the wrong URL in the built-docs repo once this gets merged.

@bmorelli25 bmorelli25 merged commit de46be1 into elastic:master Dec 21, 2021
@bmorelli25 bmorelli25 deleted the fix-apm-book-build-locations branch December 21, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants