Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds cloud and ESS attributes #902

Merged
merged 5 commits into from
May 30, 2019
Merged

Adds cloud and ESS attributes #902

merged 5 commits into from
May 30, 2019

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented May 28, 2019

This PR adds shared attributes for the terms "Elastic Cloud" and "Elasticsearch Service", as well as ESMS and data frames so they can be used consistently across the library.

@lcawl lcawl requested a review from nrichers May 28, 2019 20:06
Copy link
Contributor

@kellyemurphy kellyemurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit f8f3bbf into elastic:master May 30, 2019
@lcawl lcawl deleted the cloud-attributes branch May 30, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants